]> granicus.if.org Git - postgresql/commit
More cleanup after failed reduced-lock-levels-for-DDL feature.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 21 Oct 2011 17:49:58 +0000 (13:49 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 21 Oct 2011 17:49:58 +0000 (13:49 -0400)
commitdff178f8017e4412d14f131e4c3b5f5b385c5598
treec761fcc12904cff8ee17392d7d85bdbdeb5316d3
parent5c5138f2f8c7770e05036f991e7d29b8060d5218
More cleanup after failed reduced-lock-levels-for-DDL feature.

Turns out that use of ShareUpdateExclusiveLock or ShareRowExclusiveLock
to protect DDL changes had gotten copied into several places that were
not touched by either of Simon's original patches for the feature, and
thus neither he nor I thought to revert them.  (Indeed, it appears that
two of these uses were committed *after* the reversion, which just goes
to show that git merging is no panacea.)  Change these places to use
AccessExclusiveLock again.  If we ever manage to resurrect that feature,
we're going to have to think a bit harder about how to keep lock level
usage in sync for DDL operations that aren't within the AlterTable
infrastructure.

Two of these bugs are only in HEAD, but one is in the 9.1 branch too.
Alvaro found one of them, I found the other two.
src/backend/catalog/toasting.c