]> granicus.if.org Git - postgresql/commit
Make executor's SELECT INTO code save and restore original tuple receiver.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Jan 2012 23:30:55 +0000 (18:30 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Jan 2012 23:30:55 +0000 (18:30 -0500)
commitdfd26f9c5f371437f243249025863ea9911aacaa
treecf06e8240885e678579207f59384f432e61729f0
parent10ecc0d5867b8dd39cf506b8bb02053ede05fb60
Make executor's SELECT INTO code save and restore original tuple receiver.

As previously coded, the QueryDesc's dest pointer was left dangling
(pointing at an already-freed receiver object) after ExecutorEnd.  It's a
bit astonishing that it took us this long to notice, and I'm not sure that
the known problem case with SQL functions is the only one.  Fix it by
saving and restoring the original receiver pointer, which seems the most
bulletproof way of ensuring any related bugs are also covered.

Per bug #6379 from Paul Ramsey.  Back-patch to 8.4 where the current
handling of SELECT INTO was introduced.
src/backend/executor/execMain.c
src/test/regress/expected/select_into.out
src/test/regress/sql/select_into.sql