]> granicus.if.org Git - postgresql/commit
Fix over-aggressive sanity check in misc_sanity.sql.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Aug 2017 14:14:20 +0000 (10:14 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Aug 2017 14:14:47 +0000 (10:14 -0400)
commitdf44405a0c5c725706317c1faa6e8a0760f17dcc
tree1ca8cf01d353537e12415e8de09f97f956090b7d
parent5ecd7ccbe672a7ca2f3cd7252b28080100016fc2
Fix over-aggressive sanity check in misc_sanity.sql.

Fix thinko in commit 8be8510cf: it's okay to have dbid == 0 in normal
(non-pin) entries in pg_shdepend, because global objects such as
databases are entered that way.  The test would pass so long as it
was run in a cluster containing no databases/tablespaces owned by,
or granted to, roles other than the bootstrap superuser.  That's the
expected situation for "make check", but for "make installcheck", not
so much.

Reported by Ryan Murphy.

Discussion: https://postgr.es/m/CAHeEsBc6EQe0mxGBKDXAwJbntgfvoAd5MQC-5362SmC3Tng_6g@mail.gmail.com
src/test/regress/expected/misc_sanity.out
src/test/regress/sql/misc_sanity.sql