]> granicus.if.org Git - postgresql/commit
Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:54 +0000 (17:00 -0400)
commitdeba7c6fc3ccbaadfccbf70f73480d33a27b15b4
treea874229f78a34d80e6d95fa8879802d994fcbfde
parent92f6b49c48a3b9c829d4117d59e89128455dbf5f
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/access/heap/heapam.c
src/backend/replication/logical/reorderbuffer.c