]> granicus.if.org Git - postgresql/commit
Merge two copies of tuple-building code in pltcl.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 6 Jan 2017 21:21:57 +0000 (16:21 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 6 Jan 2017 21:22:08 +0000 (16:22 -0500)
commitde5fed0d0c704e3d1a928bf420663319d898cee4
treee0864f8edb88eea287ae299bd867a7a61d341995
parentd74ecbc8d85eb7a2aa1d5516c5c38d6ab0cbbd82
Merge two copies of tuple-building code in pltcl.c.

Make pltcl_trigger_handler() construct modified tuples using
pltcl_build_tuple_result(), rather than its own copy of essentially
the same logic.  This results in slightly different message wording for
the error cases, and in one case a different SQLSTATE, but it seems
unlikely that any existing applications are depending on any of those
details.

While at it, fix a typo in commit 26abb50c4: pltcl_build_tuple_result was
applying encoding conversion in the wrong direction.  That would be a
back-patchable bug fix, except the code hasn't shipped yet.

Jim Nasby, reviewed by me

Discussion: https://postgr.es/m/d2c6425a-d9e0-f034-f774-4a872c234d89@BlueTreble.com
src/pl/tcl/pltcl.c