]> granicus.if.org Git - postgresql/commit
Don't allow foreign tables with OIDs.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 09:31:36 +0000 (12:31 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 10:30:41 +0000 (13:30 +0300)
commitdd1a5b09bf070eff699c241b6de28453924e5613
treedb6331ae982b5850b3ef80cb0dcfec95aac52cbe
parentcbc0517c3200af091cb95c35322555f4f6782da4
Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.
src/backend/commands/tablecmds.c