]> granicus.if.org Git - python/commit
bpo-31933: fix blake2 multi-byte params on big endian platforms (#4250)
authorJack O'Connor <oconnor663@gmail.com>
Fri, 3 Nov 2017 19:02:41 +0000 (15:02 -0400)
committerChristian Heimes <christian@python.org>
Fri, 3 Nov 2017 19:02:41 +0000 (20:02 +0100)
commitdcfb0e3c04f1b29a0d09bb0a81dcd5ee5a5fef1a
tree4f160c37de78a47989bdabea0bdb3f3a44330c99
parentf6f90ff079a22b79a58d47b6117cc8a8c7d366f3
bpo-31933: fix blake2 multi-byte params on big endian platforms (#4250)

All Blake2 params have to be encoded in little-endian byte order. For
the two multi-byte integer params, leaf_length and node_offset, that
means that assigning a native-endian integer to them appears to work on
little-endian platforms, but gives the wrong result on big-endian. The
current libb2 API doesn't make that very clear, and @sneves is working
on new API functions in the GH issue above. In the meantime, we can work
around the problem by explicitly assigning little-endian values to the
parameter block.

See https://github.com/BLAKE2/libb2/issues/12.
Lib/test/test_hashlib.py
Misc/NEWS.d/next/Library/2017-11-03-08-36-03.bpo-31933.UrtoMP.rst [new file with mode: 0644]
Modules/_blake2/blake2b_impl.c
Modules/_blake2/blake2s_impl.c