]> granicus.if.org Git - postgresql/commit
Rename ResolveNew() to ReplaceVarsFromTargetList(), and tweak its API.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 8 Nov 2012 21:52:49 +0000 (16:52 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 8 Nov 2012 21:52:49 +0000 (16:52 -0500)
commitdcc55dd21aa2ba18b28ba9fa441885ef9c99d3c6
tree08de7430b4344888ecdbe65a0287c0fd13eb959b
parent75af5ae9c017d70531bd49178adfd3103cd40a76
Rename ResolveNew() to ReplaceVarsFromTargetList(), and tweak its API.

This function currently lacks the option to throw error if the provided
targetlist doesn't have any matching entry for a Var to be replaced.
Two of the four existing call sites would be better off with an error,
as would the usage in the pending auto-updatable-views patch, so it seems
past time to extend the API to support that.  To do so, replace the "event"
parameter (historically of type CmdType, though it was declared plain int)
with a special-purpose enum type.

It's unclear whether this function might be called by third-party code.
Since many C compilers wouldn't warn about a call site continuing to use
the old calling convention, rename the function to forcibly break any
such code that hasn't been updated.  The old name was none too well chosen
anyhow.
src/backend/optimizer/path/allpaths.c
src/backend/rewrite/rewriteHandler.c
src/backend/rewrite/rewriteManip.c
src/include/rewrite/rewriteManip.h