]> granicus.if.org Git - postgresql/commit
Improve qual pushdown for RLS and SB views
authorStephen Frost <sfrost@snowman.net>
Mon, 27 Apr 2015 16:29:42 +0000 (12:29 -0400)
committerStephen Frost <sfrost@snowman.net>
Mon, 27 Apr 2015 16:29:42 +0000 (12:29 -0400)
commitdcbf5948e12aa60b4d6ab65b6445897dfc971e01
tree1409202a08f721acea729ed7851ad69130cdc469
parent06ca28d5ab2f810ef25e718e0d71f2233542c151
Improve qual pushdown for RLS and SB views

The original security barrier view implementation, on which RLS is
built, prevented all non-leakproof functions from being pushed down to
below the view, even when the function was not receiving any data from
the view.  This optimization improves on that situation by, instead of
checking strictly for non-leakproof functions, it checks for Vars being
passed to non-leakproof functions and allows functions which do not
accept arguments or whose arguments are not from the current query level
(eg: constants can be particularly useful) to be pushed down.

As discussed, this does mean that a function which is pushed down might
gain some idea that there are rows meeting a certain criteria based on
the number of times the function is called, but this isn't a
particularly new issue and the documentation in rules.sgml already
addressed similar covert-channel risks.  That documentation is updated
to reflect that non-leakproof functions may be pushed down now, if
they meet the above-described criteria.

Author: Dean Rasheed, with a bit of rework to make things clearer,
along with comment and documentation updates from me.
doc/src/sgml/rules.sgml
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/util/clauses.c
src/include/optimizer/clauses.h
src/test/modules/test_rls_hooks/expected/test_rls_hooks.out
src/test/regress/expected/rowsecurity.out
src/test/regress/expected/select_views.out
src/test/regress/expected/select_views_1.out
src/test/regress/sql/rowsecurity.sql
src/test/regress/sql/select_views.sql