]> granicus.if.org Git - postgresql/commit
Improve error reporting in code that checks for buffer refcount leaks.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Mar 2013 16:26:26 +0000 (12:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Mar 2013 16:26:26 +0000 (12:26 -0400)
commitdcafdbcde1baf256891be6af77868b84889b435d
treef1c13fc6189af0d2df6270bb0a8f770183daeba4
parent73e7025bd8eed941a068f0a7a71e02dca8d38d1c
Improve error reporting in code that checks for buffer refcount leaks.

Formerly we just Assert'ed that each refcount was zero, which was quick
and easy but failed to provide a good overview of what was wrong.
Change the code so that we'll call PrintBufferLeakWarning() for each
buffer with a nonzero refcount, and then Assert at the end of the loop.
This costs nothing in runtime and might ease diagnosis of some bugs.

Greg Smith, reviewed by Satoshi Nagayasu, further tweaked by me
src/backend/storage/buffer/bufmgr.c
src/backend/storage/buffer/localbuf.c