]> granicus.if.org Git - postgresql/commit
Make checksum_impl.h safe to compile with -fstrict-aliasing.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Aug 2018 16:26:20 +0000 (12:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Aug 2018 16:27:22 +0000 (12:27 -0400)
commitdb87d3b5253f12d78dd3f8cb893c56bd4cbcfd40
treebb26132fb218b1321a454a3f7a802927d84daf4f
parent861670369093b0bd5ddae336aed6e1e3c4ce8a13
Make checksum_impl.h safe to compile with -fstrict-aliasing.

In general, Postgres requires -fno-strict-aliasing with compilers that
implement C99 strict aliasing rules.  There's little hope of getting
rid of that overall.  But it seems like it would be a good idea if
storage/checksum_impl.h in particular didn't depend on it, because
that header is explicitly intended to be included by external programs.
We don't have a lot of control over the compiler switches that an
external program might use, as shown by Michael Banck's report of
failure in a privately-modified version of pg_verify_checksums.

Hence, switch to using a union in place of willy-nilly pointer casting
inside this file.  I think this makes the code a bit more readable
anyway.

checksum_impl.h hasn't changed since it was introduced in 9.3,
so back-patch all the way.

Discussion: https://postgr.es/m/1535618100.1286.3.camel@credativ.de
src/include/storage/checksum_impl.h