]> granicus.if.org Git - postgresql/commit
Relax overly strict assertion
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
commitdb02c179d7f57d3b694670d8e8085812dc1575bd
tree50fc9949136a31044474113091fd533544a2e376
parent30bce0df865f719be91d8a1405143b47c70a2b0a
Relax overly strict assertion

Ever since its birth, ReorderBufferBuildTupleCidHash() has contained an
assertion that a catalog tuple cannot change Cmax after acquiring one.  But
that's wrong: if a subtransaction executes DDL that affects that catalog
tuple, and later aborts and another DDL affects the same tuple, it will
change Cmax.  Relax the assertion to merely verify that the Cmax remains
valid and monotonically increasing, instead.

Add a test that tickles the relevant code.

Diagnosed by, and initial patch submitted by: Arseny Sher
Co-authored-by: Arseny Sher
Discussion: https://postgr.es/m/874l9p8hyw.fsf@ars-thinkpad
contrib/test_decoding/expected/ddl.out
contrib/test_decoding/sql/ddl.sql
src/backend/replication/logical/reorderbuffer.c