]> granicus.if.org Git - graphviz/commit
Fix ASan odr_violation in mm2gv by not linking to libcommon
authorMagnus Jacobsson <Magnus.Jacobsson@berotec.se>
Tue, 25 May 2021 19:43:32 +0000 (21:43 +0200)
committerMagnus Jacobsson <Magnus.Jacobsson@berotec.se>
Sun, 30 May 2021 15:27:23 +0000 (17:27 +0200)
commitdaebd915aab9cc280ca3dde9f9949935fa5883cc
treedcba69edd02a0263c4eb23c3d96926359be957ce
parent1b258191b2d9fc892b22d7a1159f5f1c70c15f2a
Fix ASan odr_violation in mm2gv by not linking to libcommon

libcommon is a static lib, but is already part of the dynamic libgvc.

The error message was:

==73343==ERROR: AddressSanitizer: odr-violation (0x555555789760):
  [1] size=8 'fdp_parms' /home/magjac/graphviz/lib/common/globals.c:30:20
  [2] size=8 'fdp_parms' /home/magjac/graphviz/lib/common/globals.c:30:20
These globals were registered at these points:
  [1]:
    #0 0x7ffff760d938 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341
    #1 0x555555693361 in _sub_I_00099_1 (/home/magjac/build-graphviz-Desktop-Debug/cmd/tools/mm2gv+0x13f361)
    #2 0x55555569376c in __libc_csu_init (/home/magjac/build-graphviz-Desktop-Debug/cmd/tools/mm2gv+0x13f76c)

  [2]:
    #0 0x7ffff760d938 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341
    #1 0x7ffff6f7de38 in _sub_I_00099_1 (/home/magjac/build-graphviz-Desktop-Debug/lib/gvc/libgvc.so.6+0x420e38)
    #2 0x7ffff7fda96d  (/lib64/ld-linux-x86-64.so.2+0x1196d)

==73343==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'fdp_parms' at /home/magjac/graphviz/lib/common/globals.c:30:20
==73343==ABORTING
CHANGELOG.md
cmd/tools/CMakeLists.txt