]> granicus.if.org Git - postgresql/commit
Repair logic for reordering grouping sets optimization.
authorAndrew Gierth <rhodiumtoad@postgresql.org>
Sun, 30 Jun 2019 22:49:13 +0000 (23:49 +0100)
committerAndrew Gierth <rhodiumtoad@postgresql.org>
Sun, 30 Jun 2019 22:49:13 +0000 (23:49 +0100)
commitda53be23d1c5e529675e958eaee54cfed4e4dbac
treec312d87428ebd5ff945c4adc6e5ba2dae3f907b4
parentc000a47ad1fdd4fb92c7068279d97e0c3db4f8eb
Repair logic for reordering grouping sets optimization.

The logic in reorder_grouping_sets to order grouping set elements to
match a pre-specified sort ordering was defective, resulting in
unnecessary sort nodes (though the query output would still be
correct). Repair, simplifying the code a little, and add a test.

Per report from Richard Guo, though I didn't use their patch. Original
bug seems to have been my fault.

Backpatch back to 9.5 where grouping sets were introduced.

Discussion: https://postgr.es/m/CAN_9JTzyjGcUjiBHxLsgqfk7PkdLGXiM=pwM+=ph2LsWw0WO1A@mail.gmail.com
src/backend/optimizer/plan/planner.c
src/test/regress/expected/groupingsets.out
src/test/regress/sql/groupingsets.sql