]> granicus.if.org Git - postgresql/commit
Fix SortTocFromFile() to cope with lines that are too long for its buffer.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:33 +0000 (11:40 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:33 +0000 (11:40 -0400)
commitda311c7dbe4e166df9246f1df9c8ed62faea81dc
treed88bed3e841fd777b0cb9e05458833b422c5dbb3
parentfca20bcec9f4cae358044bdc66ebcb88c07c5ac2
Fix SortTocFromFile() to cope with lines that are too long for its buffer.

The original coding supposed that a dump TOC file could never contain lines
longer than 1K.  The folly of that was exposed by a recent report from
Per-Olov Esgard.  We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.

Back-patch to all supported branches, since it's always been like this.
src/bin/pg_dump/pg_backup_archiver.c