]> granicus.if.org Git - graphviz/commit
fix resource leakage in gml2gv
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sun, 13 Sep 2020 03:13:23 +0000 (20:13 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 19 Sep 2020 16:42:59 +0000 (09:42 -0700)
commitd983cbf5ee02776c588b9e6c0c2d0598842f759e
tree87457a10f681ce607b3fe48be7e8b41f5cd99945
parent5c48adbfd77a0272d6ff7c639b253100fca0792b
fix resource leakage in gml2gv

This addresses the following Coverity warning:

  Error: RESOURCE_LEAK (CWE-772): [#def51]
  graphviz-2.40.1/cmd/tools/gml2gv.c:123: alloc_fn: Storage is returned from allocation function "openFile".
  graphviz-2.40.1/cmd/tools/gml2gv.c:68:5: alloc_fn: Storage is returned from allocation function "fopen".
  graphviz-2.40.1/cmd/tools/gml2gv.c:68:5: var_assign: Assigning: "fp" = "fopen(name, mode)".
  graphviz-2.40.1/cmd/tools/gml2gv.c:79:5: return_alloc: Returning allocated memory "fp".
  graphviz-2.40.1/cmd/tools/gml2gv.c:123: var_assign: Assigning: "outFile" = storage returned from "openFile(optarg, "w")".
  graphviz-2.40.1/cmd/tools/gml2gv.c:123: overwrite_var: Overwriting "outFile" in "outFile = openFile(optarg, "w")" leaks the storage that "outFile" points to.
  #  121|         break;
  #  122|     case 'o':
  #  123|->       outFile = openFile(optarg, "w");
  #  124|         break;
  #  125|     case ':':

Related to #1464.
cmd/tools/gml2gv.c