]> granicus.if.org Git - postgresql/commit
Fold FindConversion() into FindConversionByName() and remove ACL check.
authorRobert Haas <rhaas@postgresql.org>
Tue, 2 Feb 2010 18:52:33 +0000 (18:52 +0000)
committerRobert Haas <rhaas@postgresql.org>
Tue, 2 Feb 2010 18:52:33 +0000 (18:52 +0000)
commitd8db6a6096d1b901f2ad9077148a87cd95fb3e86
treee3881ace8641de0d61b32952363d9ac395fa7fa3
parent4d32f6d7bf2e4e2715b1f79b379a7cfcca16993c
Fold FindConversion() into FindConversionByName() and remove ACL check.

All callers of FindConversionByName() already do suitable permissions
checking already apart from this function, but this is not just dead
code removal: the unnecessary permissions check can actually lead to
spurious failures - there's no reason why inability to execute the
underlying function should prohibit renaming the conversion, for example.
(The error messages in these cases were also rather poor:
FindConversion would return InvalidOid, eventually leading to a complaint
that the conversion "did not exist", which was not correct.)

KaiGai Kohei
src/backend/catalog/namespace.c
src/backend/catalog/pg_conversion.c
src/include/catalog/pg_conversion_fn.h