]> granicus.if.org Git - llvm/commit
Revert "Make naming in Host.h in line with coding standards."
authorKristof Beyls <kristof.beyls@arm.com>
Thu, 30 Mar 2017 11:06:25 +0000 (11:06 +0000)
committerKristof Beyls <kristof.beyls@arm.com>
Thu, 30 Mar 2017 11:06:25 +0000 (11:06 +0000)
commitd897ffbad47eca0b672ec4d13e58fe1ed88bd073
tree65e585a0231150a3ef277f1efebef63db6e96702
parent578991f2fdac6e71fd6a1a3d0f41ea0a11e6a63e
Revert "Make naming in Host.h in line with coding standards."

This reverts r299062, which caused build failures on Windows.
It also reverts the attempts to fix the windows builds in r299064 and r299065.
The introduction of namespace llvm::sys::detail makes MSVC, and seemingly also
mingw, complain about ambiguity with the existing namespace llvm::detail.
E.g.:
C:\b\slave\sanitizer-windows\llvm\include\llvm/Support/MathExtras.h(184): error C2872: 'detail': ambiguous symbol
C:\b\slave\sanitizer-windows\llvm\include\llvm/Support/PointerLikeTypeTraits.h(31): note: could be 'llvm::detail'
C:\b\slave\sanitizer-windows\llvm\include\llvm/Support/Host.h(80): note: or       'llvm::sys::detail'

In r299064 and r299065 I tried to fix these ambiguities, based on the errors
reported in the log files. It seems however that the build stops early when
this kind of error is encountered, and many build-then-fix-iterations on
Windows may be needed to fix this. Therefore reverting r299062 for now to
get the build working again on Windows.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299066 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/ADT/DenseSet.h
include/llvm/ADT/StringExtras.h
include/llvm/Support/Host.h
include/llvm/Support/MathExtras.h
lib/Support/Chrono.cpp
lib/Support/Host.cpp
unittests/Support/Host.cpp