]> granicus.if.org Git - postgresql/commit
Handle OID column inheritance correctly in ALTER TABLE ... INHERIT.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Jan 2017 23:00:11 +0000 (18:00 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Jan 2017 23:00:11 +0000 (18:00 -0500)
commitd86f40009b6b019f794819a9af9038cff0cac6f3
treeee8b80cde2d0d8060a88fbaa5fca2461f3c3e0fc
parent44f7afba79348883da110642d230a13003b75f62
Handle OID column inheritance correctly in ALTER TABLE ... INHERIT.

Inheritance operations must treat the OID column, if any, much like
regular user columns.  But MergeAttributesIntoExisting() neglected to
do that, leading to weird results after a table with OIDs is associated
to a parent with OIDs via ALTER TABLE ... INHERIT.

Report and patch by Amit Langote, reviewed by Ashutosh Bapat, some
adjustments by me.  It's been broken all along, so back-patch to
all supported branches.

Discussion: https://postgr.es/m/cb13cfe7-a48c-5720-c383-bb843ab28298@lab.ntt.co.jp
src/backend/commands/tablecmds.c
src/test/regress/expected/inherit.out
src/test/regress/sql/inherit.sql