]> granicus.if.org Git - postgresql/commit
Fix a couple of contrib/dblink bugs.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Apr 2012 00:43:15 +0000 (20:43 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 4 Apr 2012 00:43:15 +0000 (20:43 -0400)
commitd843ed21164275dfbfefa486bb00bca91380cdf0
tree08d2d30bf6ab06191c7c7f8775264321e71c9e0c
parent5e86c61a7eec0fdc6961493a150159fa8fc63b1c
Fix a couple of contrib/dblink bugs.

dblink_exec leaked temporary database connections if any error occurred
after connection setup, for example
SELECT dblink_exec('...connect string...', 'select 1/0');
Add a PG_TRY block to ensure PQfinish gets done when it is needed.
(dblink_record_internal is on the hairy edge of needing similar treatment,
but seems not to be actively broken at the moment.)

Also, in 9.0 and up, only one of the three functions using tuplestore
return mode was properly checking that the query context would allow
a tuplestore result.

Noted while reviewing dblink patch.  Back-patch to all supported branches.
contrib/dblink/dblink.c