]> granicus.if.org Git - python/commit
bpo-18533: Avoid RecursionError from repr() of recursive dictview (#4823)
authorbennorth <ben@redfrontdoor.org>
Fri, 26 Jan 2018 15:46:01 +0000 (15:46 +0000)
committerSenthil Kumaran <skumaran@gatech.edu>
Fri, 26 Jan 2018 15:46:01 +0000 (07:46 -0800)
commitd7773d92bd11640a8c950d6c36a9cef1cee36f96
tree31a2cf5300c58b15e50f0b480484e5beb7816c0c
parente76daebc0c8afa3981a4c5a8b54537f756e805de
bpo-18533: Avoid RecursionError from repr() of recursive dictview (#4823)

dictview_repr(): Use a Py_ReprEnter() / Py_ReprLeave() pair to check
for recursion, and produce "..." if so.

test_recursive_repr(): Check for the string rather than a
RecursionError.  (Test cannot be any tighter as contents are
implementation-dependent.)

test_deeply_nested_repr(): Add new test, replacing the original
test_recursive_repr().  It checks that a RecursionError is raised in
the case of a non-recursive but deeply nested structure.  (Very
similar to what test_repr_deep() in test/test_dict.py does for a
normal dict.)

OrderedDictTests: Add new test case, to test behavior on OrderedDict
instances containing their own values() or items().
Lib/test/test_dictviews.py
Lib/test/test_ordered_dict.py
Misc/NEWS.d/next/Core and Builtins/2017-12-13-16-46-23.bpo-18533.Dlk8d7.rst [new file with mode: 0644]
Objects/dictobject.c