]> granicus.if.org Git - postgresql/commit
Reorder code in pg_dump to dump comments etc in a uniform order.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 22 Jan 2018 17:37:11 +0000 (12:37 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 22 Jan 2018 17:37:11 +0000 (12:37 -0500)
commitd6c84667d130f19efdf0f04f7d52a6b37df0f21b
tree754f321e6a86e88019ed1669ad32f2937bc8e1bb
parentf498704346a4ce4953fc5f837cacb545b3166ee1
Reorder code in pg_dump to dump comments etc in a uniform order.

Most of the code in pg_dump dumps an object's comment, security label,
and ACL auxiliary TOC entries, in that order, immediately after the
object's main TOC entry, and at least dumpComment's API spec says this
isn't optional.  dumpDatabase was significantly violating that when
in binary-upgrade mode, by inserting totally unrelated stuff between.
Also, dumpForeignDataWrapper and dumpForeignServer were being randomly
inconsistent.  Reorder code so everybody does it the same.

This may be future-proofing us against some code growing a requirement for
such auxiliary entries to be adjacent to their main entry.  But for now
it's just neatnik-ism, so I see no need for back-patch.

Discussion: https://postgr.es/m/21714.1516553459@sss.pgh.pa.us
src/bin/pg_dump/pg_dump.c