]> granicus.if.org Git - clang/commit
Improve diagnostics when we fail to convert from a source type to a
authorDouglas Gregor <dgregor@apple.com>
Fri, 9 Apr 2010 00:35:39 +0000 (00:35 +0000)
committerDouglas Gregor <dgregor@apple.com>
Fri, 9 Apr 2010 00:35:39 +0000 (00:35 +0000)
commitd4eea8362605807327735727a9098abe1eb23b19
treeffa33b82edfd313505b5bf83dac9fd6b6e844fa9
parent355fa3a65d2bffb2cb230e5c3d8cd14ec5570329
Improve diagnostics when we fail to convert from a source type to a
destination type for initialization, assignment, parameter-passing,
etc. The main issue fixed here is that we used rather confusing
wording for diagnostics such as

t.c:2:9: warning: initializing 'char const [2]' discards qualifiers,
      expected 'char *' [-pedantic]
  char *name = __func__;
        ^      ~~~~~~~~

We're not initializing a 'char const [2]', we're initializing a 'char
*' with an expression of type 'char const [2]'. Similar problems
existed for other diagnostics in this area, so I've normalized them all
with more precise descriptive text to say what we're
initializing/converting/assigning/etc. from and to. The warning for
the code above is now:

t.c:2:9: warning: initializing 'char *' from an expression of type
      'char const [2]' discards qualifiers [-pedantic]
  char *name = __func__;
        ^      ~~~~~~~~

Fixes <rdar://problem/7447179>.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@100832 91177308-0d34-0410-b5e6-96231b3b80d8
70 files changed:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Analysis/null-deref-ps.c
test/Analysis/override-werror.c
test/CXX/except/except.handle/p16.cpp
test/FixIt/fixit-objc.m
test/PCH/functions.c
test/PCH/types.c
test/Parser/altivec.c
test/Parser/builtin_types_compatible.c
test/Parser/cxx-altivec.cpp
test/Parser/declarators.c
test/Parser/implicit-casts.c
test/Sema/address_spaces.c
test/Sema/anonymous-struct-union.c
test/Sema/array-constraint.c
test/Sema/array-init.c
test/Sema/block-call.c
test/Sema/block-misc.c
test/Sema/block-return.c
test/Sema/cast-to-union.c
test/Sema/compound-literal.c
test/Sema/conditional-expr.c
test/Sema/conditional.c
test/Sema/enum.c
test/Sema/ext_vector_casts.c
test/Sema/function-ptr.c
test/Sema/function-redecl.c
test/Sema/incompatible-sign.c
test/Sema/invalid-init-diag.c
test/Sema/pointer-conversion.c
test/Sema/predef.c
test/Sema/predefined-function.c
test/Sema/statements.c
test/Sema/struct-compat.c
test/Sema/typedef-retain.c
test/Sema/vector-assign.c
test/Sema/vector-cast.c
test/Sema/warn-write-strings.c
test/SemaCXX/copy-assignment.cpp
test/SemaCXX/derived-to-base-ambig.cpp
test/SemaCXX/member-pointer.cpp
test/SemaObjC/argument-checking.m
test/SemaObjC/block-type-safety.m
test/SemaObjC/blocks.m
test/SemaObjC/class-method-self.m
test/SemaObjC/compatible-protocol-qualified-types.m
test/SemaObjC/comptypes-1.m
test/SemaObjC/comptypes-3.m
test/SemaObjC/comptypes-6.m
test/SemaObjC/comptypes-7.m
test/SemaObjC/comptypes-legal.m
test/SemaObjC/conditional-expr-2.m
test/SemaObjC/conditional-expr-3.m
test/SemaObjC/conditional-expr-4.m
test/SemaObjC/conditional-expr.m
test/SemaObjC/id.m
test/SemaObjC/incompatible-protocol-qualified-types.m
test/SemaObjC/message.m
test/SemaObjC/method-arg-qualifier-warning.m
test/SemaObjC/protocol-id-test-3.m
test/SemaObjC/protocol-typecheck.m
test/SemaObjC/protocol-warn.m
test/SemaObjC/warn-incompatible-builtin-types.m
test/SemaObjC/warn-write-strings.m
test/SemaObjCXX/blocks.mm
test/SemaObjCXX/objc-pointer-conv.mm
test/SemaObjCXX/void_to_obj.mm
test/SemaTemplate/fun-template-def.cpp
test/SemaTemplate/instantiate-member-class.cpp