]> granicus.if.org Git - clang/commit
Make 'LangOptions' in CompilerInvocation a heap-allocated, reference counted object...
authorTed Kremenek <kremenek@apple.com>
Thu, 17 Nov 2011 23:01:24 +0000 (23:01 +0000)
committerTed Kremenek <kremenek@apple.com>
Thu, 17 Nov 2011 23:01:24 +0000 (23:01 +0000)
commitd3b74d9ca4f239a7a90ad193378c494306c57352
tree65d677835cc2b3e9625285be0f165d5b6e9e8a65
parentd04a982d3472d98e58f58dfc327ca11e236980f5
Make 'LangOptions' in CompilerInvocation a heap-allocated, reference counted object.  I discovered that llvm::RefCountedBase<T> has
a bug where the reference count is copied in the copy constructor, which means that there were cases when the CompilerInvocation
objects created by ASTUnit were actually leaked.  When I fixed that bug locally, it showed that a whole bunch of code assumed
that the LangOptions object that was part of CompilerInvocation was still alive.  By making it heap-allocated and reference counted,
we can keep it around after the CompilerInvocation object goes away.

As part of this change, change CompilerInvocation:getLangOptions() to return a pointer, acting as another clue that this
object may outlive the CompilerInvocation object.

This commit doesn't fix the CompilerInvocation leak itself.  That will come when I commit the fix to llvm::RefCountedBase<T> to
mainline LLVM.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@144930 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/LangOptions.h
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/CompilerInstance.h
include/clang/Frontend/CompilerInvocation.h
lib/ARCMigrate/ARCMT.cpp
lib/Frontend/ASTUnit.cpp
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
tools/arcmt-test/arcmt-test.cpp
tools/libclang/Indexing.cpp