]> granicus.if.org Git - postgresql/commit
Disallow SELECT FOR UPDATE/SHARE on sequences.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jun 2011 18:46:31 +0000 (14:46 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jun 2011 18:46:31 +0000 (14:46 -0400)
commitd369ddd9f1d5908e36616e5b9e953ecefde43be4
treeb8c0945c7d0c131e54a5ff5da3e837a60735e7f6
parentca76a3956c80f97eb4ea0cc8fc2a54435f6a573b
Disallow SELECT FOR UPDATE/SHARE on sequences.

We can't allow this because such an operation stores its transaction XID
into the sequence tuple's xmax.  Because VACUUM doesn't process sequences
(and we don't want it to start doing so), such an xmax value won't get
frozen, meaning it will eventually refer to nonexistent pg_clog storage,
and even wrap around completely.  Since the row lock is ignored by nextval
and setval, the usefulness of the operation is highly debatable anyway.
Per reports of trouble with pgpool 3.0, which had ill-advisedly started
using such commands as a form of locking.

In HEAD, also disallow SELECT FOR UPDATE/SHARE on toast tables.  Although
this does work safely given the current implementation, there seems no
good reason to allow it.  I refrained from changing that behavior in
back branches, however.
src/backend/executor/execMain.c