]> granicus.if.org Git - graphviz/commit
fix ortho: add epsilon to floating point comparison
authorCosta Shulyupin <constantine.shulyupin@gmail.com>
Mon, 16 May 2022 07:05:55 +0000 (10:05 +0300)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 11 Jun 2022 18:29:46 +0000 (11:29 -0700)
commitd3248f7b8e965af98f4a3e1e47da716e41db2ff9
treeaa7e1be06d801c34c619ad2f00ef6012ae58b1b2
parent20bb8ced233113d0824bd96f19f858037792d8c2
fix ortho: add epsilon to floating point comparison

Thanks to good bug description #1408, I've compared logs of
bad and good version. I found that sometimes there is
difference ~1E-15 between t->hi.y and t->lo.y because of
precision issues. It caused false positive conditional statement.

The workaround is to tolerate insignificant deviations.

fixes #1408, fixes #1990, fixes #1658
CHANGELOG.md
lib/ortho/partition.c
tests/test_regression.py