]> granicus.if.org Git - clang/commit
[Modules] Handle sanitizer feature mismatches when importing modules
authorVedant Kumar <vsk@apple.com>
Thu, 1 Jun 2017 20:01:01 +0000 (20:01 +0000)
committerVedant Kumar <vsk@apple.com>
Thu, 1 Jun 2017 20:01:01 +0000 (20:01 +0000)
commitd2f497236f66527ad5d026e47887c63e540d6d5d
tree1069081f3f6442642965ff4240fd00790ed79c82
parent10aee78afb384ad8c70cb9e9183ff39c032e8caf
[Modules] Handle sanitizer feature mismatches when importing modules

This patch makes it an error to have a mismatch between the enabled
sanitizers in a CU, and in any module being imported into the CU. Only
mismatches between non-modular sanitizers are treated as errors.

This patch also includes non-modular sanitizers in module hashes, in
order to ensure module rebuilds occur when -fsanitize=X is toggled on
and off for non-modular sanitizers, and to cut down on module rebuilds
when the option is toggled for modular sanitizers.

This fixes a longstanding issue with implicit modules and sanitizers,
which Duncan originally diagnosed.

When building with implicit modules it's possible to hit a scenario
where modules are built without -fsanitize=address, and are subsequently
imported into CUs with -fsanitize=address enabled. This causes strange
failures at runtime. The case Duncan found affects libcxx, since its
vector implementation behaves differently when ASan is enabled.

Implicit module builds should "just work" when -fsanitize=X is toggled
on and off across multiple compiler invocations, which is what this
patch does.

Differential Revision: https://reviews.llvm.org/D32724

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@304463 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/Sanitizers.h
lib/Basic/LangOptions.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Serialization/ASTReader.cpp
test/Modules/Inputs/check-for-sanitizer-feature/check.h [new file with mode: 0644]
test/Modules/Inputs/check-for-sanitizer-feature/map [new file with mode: 0644]
test/Modules/check-for-sanitizer-feature.cpp [new file with mode: 0644]