]> granicus.if.org Git - postgresql/commit
Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 24 Aug 2011 19:16:17 +0000 (15:16 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 24 Aug 2011 19:16:50 +0000 (15:16 -0400)
commitd1d388603e4f9233d3e01847405b239972a54fdf
tree7706216f61ffa62f2cecf5ebdb1c8a721615848c
parent4803de6f8932e2f2b96bb1243ba07a05cd2c3ae5
Fix pgxs.mk to always add  --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.

The previous coding resulted in contrib modules unintentionally overriding
the use of CONTRIB_TESTDB.  There seems no particularly good reason to
allow that (after all, the makefile can set CONTRIB_TESTDB if that's really
what it intends).

In passing, document REGRESS_OPTS where the other pgxs.mk options are
documented.

Back-patch to 9.1 --- in prior versions, there were no cases of contrib
modules setting REGRESS_OPTS without including the --dbname switch, so
while the coding was fragile there was no actual bug.
contrib/sepgsql/Makefile
doc/src/sgml/extend.sgml
src/makefiles/pgxs.mk