]> granicus.if.org Git - postgresql/commit
Still further tweaking of deadlock isolation tests.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Feb 2016 19:19:57 +0000 (14:19 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Feb 2016 19:19:57 +0000 (14:19 -0500)
commitd03130d378b5fb071d231a7822784ad87268583a
tree720d4f0121717e6e3f4245e20a48a24f654de1f0
parent9c9782f066e0ce5424b8706df2cce147cb78170f
Still further tweaking of deadlock isolation tests.

It turns out that there is a second race condition in the new deadlock-hard
test: once the deadlock detector fires, it's uncertain whether step s7a8 or
step s8a1 will report first, because killing s8's transaction unblocks s7.
So far, s7 has only been seen to report first in CLOBBER_CACHE_ALWAYS
builds, but it's pretty reproducible there, and in theory it should
sometimes occur in normal builds too.  If s7 were a bit slower than usual,
that could also break the test, since the existing expected-file assumes
that we'll see s7a8 report the first time we check it after s8a1 completes.
To fix, add a post-lock delay to s7a8.
src/test/isolation/expected/deadlock-hard.out
src/test/isolation/specs/deadlock-hard.spec