]> granicus.if.org Git - postgresql/commit
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.
authorNoah Misch <noah@leadboat.com>
Sun, 12 May 2019 17:33:05 +0000 (10:33 -0700)
committerNoah Misch <noah@leadboat.com>
Sun, 12 May 2019 17:33:05 +0000 (10:33 -0700)
commitd02768ddd1791bab742cf131de726d0a36b3f337
treea2fa885d9a7076c75d96634467e196ba347ec7e5
parent85ccb6899c6c8639bb3e5962ea3bcce5d886e613
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

The function had been interpreting SQL_ASCII messages as UTF8, throwing
an error when they were invalid UTF8.  The new behavior is consistent
with pg_do_encoding_conversion().  This affects LOG_DESTINATION_STDERR
and LOG_DESTINATION_EVENTLOG, which will send untranslated bytes to
write() and ReportEventA().  On buildfarm member bowerbird, enabling
log_connections caused an error whenever the role name was not valid
UTF8.  Back-patch to 9.4 (all supported versions).

Discussion: https://postgr.es/m/20190512015615.GD1124997@rfd.leadboat.com
src/backend/utils/mb/mbutils.c
src/bin/pg_dump/t/010_dump_connstr.pl
src/bin/scripts/t/200_connstr.pl