]> granicus.if.org Git - pdns/commit
dnsdist: Fix detection of NoData / NXDomain answers in the cache
authorRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 9 Jul 2018 14:29:36 +0000 (16:29 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 9 Jul 2018 14:29:36 +0000 (16:29 +0200)
commitcfd669b489f1cdb1b90bfca9bc79af7d289f1aee
tree8d43c8a564c426eeb1cdc1f79872208628ace28f
parentfed6216456d9408fad14c63ecbb752ddc0de5cd9
dnsdist: Fix detection of NoData / NXDomain answers in the cache

Checking whether the SOA record is in the right section was broken
because of a misplaced parenthesis, and the unit test checking that
case turned out to be broken too (wrong class) :'(
The broken check was reported by cppcheck (thanks!):

```
Comparison of a boolean expression with an integer.
```
pdns/dnsparser.cc
pdns/test-dnsparser_cc.cc