]> granicus.if.org Git - ipset/commit
Removed invalid IPSET_ATTR_MARKMASK validation
authorVytas Dauksa <vytas.dauksa@smoothwall.net>
Fri, 4 Apr 2014 15:10:14 +0000 (16:10 +0100)
committerJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Mon, 7 Apr 2014 19:59:51 +0000 (21:59 +0200)
commitcf5e55f3bab6696e72dfb59bf31064678e391891
tree7d5933404bb0d5b2f76475bed2df9723e7336ba4
parentf7cafd65feda94b6f21c6b6e36e2bf258e2563d3
Removed invalid IPSET_ATTR_MARKMASK validation

Markmask is an u32, hence it can't be greater then 4294967295 ( i.e.
0xffffffff ). This was causing smatch warning:
 net/netfilter/ipset/ip_set_hash_gen.h:1084 hash_ipmark_create() warn:
 impossible condition '(markmask > 4294967295) => (0-u32max > u32max)'

Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
kernel/net/netfilter/ipset/ip_set_hash_gen.h