]> granicus.if.org Git - postgresql/commit
Fix pg_basebackup output to stdout on Windows.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 14 Jul 2017 13:02:53 +0000 (16:02 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 14 Jul 2017 13:03:05 +0000 (16:03 +0300)
commitcedd25ae8877cb7a465c3b42db7dab20873e162c
tree4005c7e0e7d93c20f2f4af87a0278dcb0de9cfce
parent3b0c2dbed07e52b73a87d94ed128784eb5c25de7
Fix pg_basebackup output to stdout on Windows.

When writing a backup to stdout with pg_basebackup on Windows, put stdout
to binary mode. Any CR bytes in the output will otherwise be output
incorrectly as CR+LF.

In the passing, standardize on using "_setmode" instead of "setmode", for
the sake of consistency. They both do the same thing, but according to
MSDN documentation, setmode is deprecated.

Fixes bug #14634, reported by Henry Boehlert. Patch by Haribabu Kommi.
Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/20170428082818.24366.13134@wrigleys.postgresql.org
src/bin/pg_basebackup/pg_basebackup.c
src/bin/pg_dump/pg_backup_archiver.c