]> granicus.if.org Git - curl/commit
url: don't set appconnect time for non-ssl/non-ssh connections
authorJay Satiro <raysatiro@yahoo.com>
Fri, 12 Apr 2019 22:57:53 +0000 (18:57 -0400)
committerJay Satiro <raysatiro@yahoo.com>
Thu, 26 Sep 2019 07:04:26 +0000 (03:04 -0400)
commitcded9937007a1cad58dc66b62109b27d70b69b90
tree9699f3d9b411b783e7f4e10079abc4ba5890f3bc
parent217812fa9ec9417edbcafae90ec50402faacba96
url: don't set appconnect time for non-ssl/non-ssh connections

Prior to this change non-ssl/non-ssh connections that were reused set
TIMER_APPCONNECT [1]. Arguably that was incorrect since no SSL/SSH
handshake took place.

[1]: TIMER_APPCONNECT is publicly known as CURLINFO_APPCONNECT_TIME in
libcurl and %{time_appconnect} in the curl tool. It is documented as
"the time until the SSL/SSH handshake is completed".

Reported-by: Marcel Hernandez
Ref: https://github.com/curl/curl/issues/3760

Closes https://github.com/curl/curl/pull/3773
lib/url.c
lib/urldata.h