]> granicus.if.org Git - postgresql/commit
Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.
authorNoah Misch <noah@leadboat.com>
Mon, 1 Jul 2019 00:34:17 +0000 (17:34 -0700)
committerNoah Misch <noah@leadboat.com>
Mon, 1 Jul 2019 00:34:20 +0000 (17:34 -0700)
commitcd9d48969d944c3558a77745db389e8b68b46c4b
tree0a318da442c5f763a0c55ad76cdca24b159b4168
parenta1637caee9c77e30aaf4afb5c51e15cb67c4f3e3
Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.

UBSan complains about this.  Instead, cast to a suitable type requiring
only 4-byte alignment.  DatumGetAnyArrayP() already assumes one can cast
between AnyArrayType and ArrayType, so this doesn't introduce a new
assumption.  Back-patch to 9.5, where AnyArrayType was introduced.

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20190629210334.GA1244217@rfd.leadboat.com
src/backend/utils/adt/arrayfuncs.c
src/include/utils/array.h
src/include/utils/arrayaccess.h
src/include/utils/expandeddatum.h