]> granicus.if.org Git - clang/commit
Improve support of PDB as an external layout source
authorAleksandr Urakov <aleksandr.urakov@jetbrains.com>
Tue, 31 Jul 2018 08:27:06 +0000 (08:27 +0000)
committerAleksandr Urakov <aleksandr.urakov@jetbrains.com>
Tue, 31 Jul 2018 08:27:06 +0000 (08:27 +0000)
commitcd5b56f4ccdd9fe19700b9ea45bf754fe34648a5
treea2cf2b18c782aaca37cd3783cc67c90459d834ae
parenta7a88118684e7ea75ae229b1ae9b2ac31c7d5fcc
Improve support of PDB as an external layout source

Summary:
This patch improves support of PDB as an external layout source
in the next cases:

- Multiple non-virtual inheritance from packed base classes. When using
  external layout, there's no need to align `NonVirtualSize` of a base class.
  It may cause an overlapping when the next base classes will be layouted
  (but there is a slightly different case in the test because I can't find
  a way to specify a base offset);
- Support of nameless structs and unions. There is no info about nameless child
  structs and unions in Microsoft cl-emitted PDBs. Instead all its fields
  are just treated as outer structure's (union's) fields. This also causes
  a fields overlapping, and makes it possible for unions to have fields located
  at a non-zero offset.

Reviewers: rsmith, zturner, rnk, mstorsjo, majnemer

Reviewed By: rnk

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D49871

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@338353 91177308-0d34-0410-b5e6-96231b3b80d8
lib/AST/RecordLayoutBuilder.cpp
test/CodeGenCXX/Inputs/override-layout-nameless-struct-union.layout [new file with mode: 0644]
test/CodeGenCXX/Inputs/override-layout-packed-base.layout [new file with mode: 0644]
test/CodeGenCXX/override-layout-nameless-struct-union.cpp [new file with mode: 0644]
test/CodeGenCXX/override-layout-packed-base.cpp [new file with mode: 0644]