]> granicus.if.org Git - postgresql/commit
Use slots more widely in tuple mapping code and make naming more consistent.
authorAndres Freund <andres@anarazel.de>
Tue, 2 Oct 2018 18:14:26 +0000 (11:14 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 2 Oct 2018 18:14:26 +0000 (11:14 -0700)
commitcc2905e963e950d01cd2cb6c860638ce9506c63d
treedeced53c4772484db83b21d85f7d50b17a21fa39
parent625b38ea0e98cb596b393c70e5eaba67c6f4279e
Use slots more widely in tuple mapping code and make naming more consistent.

It's inefficient to use a single slot for mapping between tuple
descriptors for multiple tuples, as previously done when using
ConvertPartitionTupleSlot(), as that means the slot's tuple descriptors
change for every tuple.

Previously we also, via ConvertPartitionTupleSlot(), built new tuples
after the mapping even in cases where we, immediately afterwards,
access individual columns again.

Refactor the code so one slot, on demand, is used for each
partition. That avoids having to change the descriptor (and allows to
use the more efficient "fixed" tuple slots). Then use slot->slot
mapping, to avoid unnecessarily forming a tuple.

As the naming between the tuple and slot mapping functions wasn't
consistent, rename them to execute_attr_map_{tuple,slot}.  It's likely
that we'll also rename convert_tuples_by_* to denote that these
functions "only" build a map, but that's left for later.

Author: Amit Khandekar and Amit Langote, editorialized by me
Reviewed-By: Amit Langote, Amit Khandekar, Andres Freund
Discussion:
    https://postgr.es/m/CAJ3gD9fR0wRNeAE8VqffNTyONS_UfFPRpqxhnD9Q42vZB+Jvpg@mail.gmail.com
    https://postgr.es/m/e4f9d743-cd4b-efb0-7574-da21d86a7f36%40lab.ntt.co.jp
Backpatch: -
src/backend/access/common/tupconvert.c
src/backend/commands/analyze.c
src/backend/commands/copy.c
src/backend/commands/trigger.c
src/backend/executor/execExprInterp.c
src/backend/executor/execMain.c
src/backend/executor/execPartition.c
src/backend/executor/nodeModifyTable.c
src/include/access/tupconvert.h
src/include/executor/execPartition.h
src/pl/plpgsql/src/pl_exec.c