]> granicus.if.org Git - postgresql/commit
Avoid deadlocks during insertion into SP-GiST indexes.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 14 Jun 2013 18:26:50 +0000 (14:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 14 Jun 2013 18:26:50 +0000 (14:26 -0400)
commitcbabf50dccc29aed456a56ae8909d4d593c3ab38
tree3e8d1816d2af7de2f1b2092bdda9bdad19f9526b
parent7e0b9ed6c52bc19221c401859a2cfc3c8b07b43f
Avoid deadlocks during insertion into SP-GiST indexes.

SP-GiST's original scheme for avoiding deadlocks during concurrent index
insertions doesn't work, as per report from Hailong Li, and there isn't any
evident way to make it work completely.  We could possibly lock individual
inner tuples instead of their whole pages, but preliminary experimentation
suggests that the performance penalty would be huge.  Instead, if we fail
to get a buffer lock while descending the tree, just restart the tree
descent altogether.  We keep the old tuple positioning rules, though, in
hopes of reducing the number of cases where this can happen.

Teodor Sigaev, somewhat edited by Tom Lane
src/backend/access/spgist/README
src/backend/access/spgist/spgdoinsert.c
src/backend/access/spgist/spginsert.c
src/include/access/spgist_private.h