]> granicus.if.org Git - clang/commit
[codeview] Make "clang -g" emit codeview by default when targetting MSVC
authorReid Kleckner <rnk@google.com>
Wed, 14 Nov 2018 22:59:27 +0000 (22:59 +0000)
committerReid Kleckner <rnk@google.com>
Wed, 14 Nov 2018 22:59:27 +0000 (22:59 +0000)
commitcb3989d3ad3cd59b735b5a68f70461a925991f73
tree31895edfcd9fa86087e4ce27f7405d88bfb4443c
parent761a1b5dc47fc195760dd66b6cfdea3924ca3af8
[codeview] Make "clang -g" emit codeview by default when targetting MSVC

Summary:
If you're using the Microsoft ABI, chances are that you want PDBs and
codeview debug info. Currently, everyone has to remember to specific
-gcodeview by default, when it would be nice if the standard -g option
did the right thing by default.

Also, do some related cleanup of -cc1 options. When targetting the MS
C++ ABI, we probably shouldn't pass -debugger-tuning=gdb. We were also
passing -gcodeview twice, which is silly.

Reviewers: smeenai, zturner

Subscribers: aprantl, JDevlieghere, llvm-commits

Differential Revision: https://reviews.llvm.org/D54499

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@346907 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/DebugInfoOptions.h
include/clang/Driver/ToolChain.h
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/MSVC.h
test/CodeGen/dwarf-version.c
test/CodeGenCXX/debug-info-byval.cpp
test/CodeGenCXX/debug-info-ctor2.cpp
test/CodeGenCXX/debug-info-member.cpp
test/CodeGenCXX/debug-info-method-spec.cpp
test/Driver/debug-options.c