]> granicus.if.org Git - python/commit
Fixes issue #16140: The subprocess module no longer double closes its
authorGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 09:38:18 +0000 (01:38 -0800)
committerGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 09:38:18 +0000 (01:38 -0800)
commitc8ac03d936fd9fa7b48c0aaac01b66e8d8fcf766
tree17694b3e6aa5de57be8c50335e735b5c51ae7ae9
parent6893732c353ed7cbd2492164aa2b7c64a9f1c840
parent12489d98e692717a93694644dac4975d54106178
Fixes issue #16140: The subprocess module no longer double closes its
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
Lib/subprocess.py
Lib/test/test_subprocess.py
Misc/NEWS