]> granicus.if.org Git - postgresql/commit
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:50:04 +0000 (20:50 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:50:04 +0000 (20:50 +0000)
commitc83c22d05327805d4014088e70ae20d0284e7adf
tree10cbb0e0148c88194d692878c804180372a3f815
parent2e5a61f919f0f26045f0e4baefdd7ac704ba4910
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
lock the target relation just once per SQL function call.  The original coding
obtained and released lock several times per call.  Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently.  Also
centralize locking and permission-checking logic.

Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.
contrib/dblink/dblink.c