]> granicus.if.org Git - postgresql/commit
Fix volatile vs. pointer confusion
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 14 Mar 2019 07:25:25 +0000 (08:25 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 15 Mar 2019 07:38:45 +0000 (08:38 +0100)
commitc77f21899ac2bd85d9d30d2dbf60904498ebee2f
tree250317a400ec9b66f0575abf1817440578b252dc
parentd4b754c876d3338f314c9610e424083cfaff0717
Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com
contrib/hstore_plpython/hstore_plpython.c