]> granicus.if.org Git - postgresql/commit
Reducing the assumed alignment of struct varlena means that the compiler
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 Feb 2008 17:47:47 +0000 (17:47 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 Feb 2008 17:47:47 +0000 (17:47 +0000)
commitc6f401573f1c439f018849131ac18f8199f7085c
tree3f8b0f417f6cb891e64dcb0078c44bcce86ada81
parentb7394915520b29fb2d164ad4c55fd9adf51c14df
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unaligned
address.  Which will not work if the variable is then manipulated with
SET_VARSIZE or other macros that assume alignment.  So the previous patch
is not an unalloyed good, but on balance I think it's still a win, since
we have very few places that do that sort of thing.  Fix the one place in
tuptoaster.c that does it.  Per buildfarm results from gypsy_moth
(I'm a bit surprised that only one machine showed a failure).
src/backend/access/heap/tuptoaster.c