]> granicus.if.org Git - postgresql/commit
Reducing the assumed alignment of struct varlena means that the compiler
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 Feb 2008 17:47:41 +0000 (17:47 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 Feb 2008 17:47:41 +0000 (17:47 +0000)
commitc67f6f2f573064c206044b44a73cdf0806dfbd4e
tree043e7f28413987e5e856f1fdbc1912dabdab78cd
parent2d2b0222677fb00b09ee724127a6643c3d451af3
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unaligned
address.  Which will not work if the variable is then manipulated with
SET_VARSIZE or other macros that assume alignment.  So the previous patch
is not an unalloyed good, but on balance I think it's still a win, since
we have very few places that do that sort of thing.  Fix the one place in
tuptoaster.c that does it.  Per buildfarm results from gypsy_moth
(I'm a bit surprised that only one machine showed a failure).
src/backend/access/heap/tuptoaster.c