]> granicus.if.org Git - python/commit
Fix a problem reported by Oleg Broytmann, who complains that very
authorGuido van Rossum <guido@python.org>
Wed, 24 May 2000 13:21:46 +0000 (13:21 +0000)
committerGuido van Rossum <guido@python.org>
Wed, 24 May 2000 13:21:46 +0000 (13:21 +0000)
commitc580dae6da60aa76e9b885ddbf7a9833aa61c147
tree16a176a113749007eda867ad270719643afb6a62
parenta570c059976b4ed402f2edc7c44b378475ae50a6
Fix a problem reported by Oleg Broytmann, who complains that very
often, ftp URLs hang in the final close.  Further analysis suggests
that this is because the close hook in addclosehook() calls the hook
before acually closing the connection.  The hook, in this case, waits
for the '226 Transfer complete' status from the server on the command
socket.  However, more and more ftp servers only send this status when
the data socket has actually been closed -- causing a deadlock.

The fix is simple: in addclosehook.close(), call addbase.close()
*before* calling the closehook.
Lib/urllib.py