]> granicus.if.org Git - clang/commit
IR, Bitcode: Change bitcode reader to no longer own its memory buffer.
authorPeter Collingbourne <peter@pcc.me.uk>
Tue, 8 Nov 2016 06:03:43 +0000 (06:03 +0000)
committerPeter Collingbourne <peter@pcc.me.uk>
Tue, 8 Nov 2016 06:03:43 +0000 (06:03 +0000)
commitc5671c52da870a56727a579f6ff87c0a22e688b9
treef311c32c8a27ca9096ac6545d200dfc74b43a479
parentf092121b2d390e791dc2dd87e4cd73d4fe582073
IR, Bitcode: Change bitcode reader to no longer own its memory buffer.

Unique ownership is just one possible ownership pattern for the memory buffer
underlying the bitcode reader. In practice, as this patch shows, ownership can
often reside at a higher level. With the upcoming change to allow multiple
modules in a single bitcode file, it will no longer be appropriate for
modules to generally have unique ownership of their memory buffer.

The C API exposes the ownership relation via the LLVMGetBitcodeModuleInContext
and LLVMGetBitcodeModuleInContext2 functions, so we still need some way for
the module to own the memory buffer. This patch does so by adding an owned
memory buffer field to Module, and using it in a few other places where it
is convenient.

Differential Revision: https://reviews.llvm.org/D26384

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@286214 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/CodeGenAction.cpp