Recommit r308327 2nd time: Add a warning for missing
authorAlex Lorenz <arphaman@gmail.com>
Wed, 26 Jul 2017 12:20:57 +0000 (12:20 +0000)
committerAlex Lorenz <arphaman@gmail.com>
Wed, 26 Jul 2017 12:20:57 +0000 (12:20 +0000)
commitc4f5f6916def820e248a43a87774032c5ce70dc3
treea58e33f834692e754ad217f253a2d833f175e4c9
parentf3de089985f96513b2602937c56399b42c7a5959
Recommit r308327 2nd time: Add a warning for missing
'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files

The first recommit (r308441) caused a "non-default #pragma pack value might
change the alignment of struct or union members in the included file" warning
in LLVM itself. This recommit tweaks the added warning to avoid warnings for
#includes that don't have any records that are affected by the non-default
alignment. This tweak avoids the previously emitted warning in LLVM.

Original message:

This commit adds a new -Wpragma-pack warning. It warns in the following cases:

- When a translation unit is missing terminating #pragma pack (pop) directives.
- When entering an included file if the current alignment value as determined
  by '#pragma pack' directives is different from the default alignment value.
- When leaving an included file that changed the state of the current alignment
  value.

rdar://10184173

Differential Revision: https://reviews.llvm.org/D35484

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@309106 91177308-0d34-0410-b5e6-96231b3b80d8
22 files changed:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Lex/PPCallbacks.h
include/clang/Sema/Sema.h
include/clang/Serialization/ASTReader.h
lib/Parse/ParsePragma.cpp
lib/Sema/Sema.cpp
lib/Sema/SemaAttr.cpp
lib/Serialization/ASTReader.cpp
lib/Serialization/ASTWriter.cpp
test/OpenMP/declare_simd_messages.cpp
test/PCH/pragma-pack.c
test/PCH/suspicious-pragma-pack.c [new file with mode: 0644]
test/Parser/pragma-options.c
test/Parser/pragma-options.cpp
test/Parser/pragma-pack.c
test/Sema/Inputs/pragma-pack1.h [new file with mode: 0644]
test/Sema/Inputs/pragma-pack2.h [new file with mode: 0644]
test/Sema/pragma-pack.c
test/Sema/suspicious-pragma-pack.c [new file with mode: 0644]
test/SemaObjC/Inputs/empty.h [new file with mode: 0644]
test/SemaObjC/suspicious-pragma-pack.m [new file with mode: 0644]