]> granicus.if.org Git - postgresql/commit
Fix failure of archive recovery with recovery_min_apply_delay enabled.
authorFujii Masao <fujii@postgresql.org>
Fri, 18 Oct 2019 13:32:18 +0000 (22:32 +0900)
committerFujii Masao <fujii@postgresql.org>
Fri, 18 Oct 2019 13:35:19 +0000 (22:35 +0900)
commitc455ee88ccae71ce6a13f7a34aead66aac0ed7c3
treeafa762a28eeec7d47d004d0967f329c4ab34e6c5
parent47698b4b62e3b7aad7e35d86b7ccdaa62799b435
Fix failure of archive recovery with recovery_min_apply_delay enabled.

recovery_min_apply_delay parameter is intended for use with streaming
replication deployments. However, the document clearly explains that
the parameter will be honored in all cases if it's specified. So it should
take effect even if in archive recovery. But, previously, archive recovery
with recovery_min_apply_delay enabled always failed, and caused assertion
failure if --enable-caasert is enabled.

The cause of this problem is that; the ownership of recoveryWakeupLatch
that recovery_min_apply_delay uses was taken only when standby mode
is requested. So unowned latch could be used in archive recovery, and
which caused the failure.

This commit changes recovery code so that the ownership of
recoveryWakeupLatch is taken even in archive recovery. Which prevents
archive recovery with recovery_min_apply_delay from failing.

Back-patch to v9.4 where recovery_min_apply_delay was added.

Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAHGQGwEyD6HdZLfdWc+95g=VQFPR4zQL4n+yHxQgGEGjaSVheQ@mail.gmail.com
src/backend/access/transam/xlog.c