]> granicus.if.org Git - postgresql/commit
Consolidate cross-option checks in pg_restore
authorMichael Paquier <michael@paquier.xyz>
Tue, 30 Oct 2018 02:38:35 +0000 (11:38 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 30 Oct 2018 02:38:35 +0000 (11:38 +0900)
commitc34bca9ea55e1d7c207ebc30691a8d2b421100eb
treef698d2a307c0b158aa1ac019cc6cb4fb5ebbc10a
parentd5eec4eefde70414c9929b32c411cb4f0900a2a9
Consolidate cross-option checks in pg_restore

This moves one check for conflicting options from the archive restore
code to the main function where other similar checks are performed.
Also reword the error message to be consistent with other messages.

The only option combination impacted is --create specified with
--single-transaction, and informing the caller at an early step saves
from opening the archive worked on.  A TAP test is added for this
combination.

Author: Daniel Gustafsson
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/616808BD-4B59-4E6C-97A9-7317F62D5570@yesql.se
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_restore.c
src/bin/pg_dump/t/001_basic.pl