]> granicus.if.org Git - python/commit
Fixes issue #16140: The subprocess module no longer double closes its
authorGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 09:41:49 +0000 (01:41 -0800)
committerGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 09:41:49 +0000 (01:41 -0800)
commitc2c4cb624bac98e0fdb52258655d26c385a35335
tree3274ada131123110abcb0561cfa4fec9a742548b
parentd4b645ef423667f179f136bee711b8ca85bd28d8
parentc8ac03d936fd9fa7b48c0aaac01b66e8d8fcf766
Fixes issue #16140: The subprocess module no longer double closes its
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
Lib/subprocess.py
Lib/test/test_subprocess.py
Misc/NEWS